Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json naming more universal #5

Open
MAA-Novicell opened this issue Jan 11, 2022 · 1 comment
Open

package.json naming more universal #5

MAA-Novicell opened this issue Jan 11, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@MAA-Novicell
Copy link

Would it make sense to rename this code to be more universal, if you by any chance don't stick with webpack:

"scripts": {
    "build:webpack": "webpack --progress --node-env production",
    "watch:webpack": "webpack --watch --node-env development",
    "start": "npm-run-all --parallel watch"
},

To just something like "build" and "watch"

"scripts": {
    "build": "webpack --progress --node-env production",
    "watch": "webpack --watch --node-env development",
    "start": "npm-run-all --parallel watch"
},
@misterwinther misterwinther added the enhancement New feature or request label Jan 12, 2022
@misterwinther
Copy link
Collaborator

@MAA-Novicell The naming was originally part of other tasks being run in parallel (hence the npm-run-all). But some tasks were removed during cleanup process. We are thinking about building a better script pack - also replacing some of the existing.
But great catch. An update will come in the not for distant future :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants