Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for parsing array params from websocket #272

Closed
omritoptix opened this issue Mar 5, 2023 · 1 comment · Fixed by #274
Closed

Add support for parsing array params from websocket #272

omritoptix opened this issue Mar 5, 2023 · 1 comment · Fixed by #274
Assignees
@omritoptix
Labels
C:rpc

Comments

@omritoptix
Copy link
Contributor

omritoptix commented Mar 5, 2023 •
edited
Loading

Currently dymint only supports map type messages sent over websocket when subscribing to an rpc method.
As a result some keplr functionalities don't work as they pass the arguments as array and not as map.
@omritoptix omritoptix self-assigned this Mar 5, 2023
@omritoptix
Copy link
Contributor Author

Currently dymint uses the gorilla toolkit (specifically the rpc repo) for handling this unmarshaling. However they have an open bug which isn't gonna be fixed as the library is not maintained anymore.

as temporary solution we're gonna clone the library and fix the bug in our clone.
Longer term we need to migrate from this library to a well maintained one.

@omritoptix omritoptix linked a pull request Mar 5, 2023 that will close this issue
fix: fixed the unmarshall of array to an object on websocket #274
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omritoptix omritoptix

Labels
C:rpc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fixed the unmarshall of array to an object on websocket dymensionxyz/dymint
1 participant
@omritoptix