Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FullNodeProcessProposalHandler fails to decode txs #1766

Open
zhaowenlan1779 opened this issue Jun 25, 2024 · 1 comment
Open

FullNodeProcessProposalHandler fails to decode txs #1766

zhaowenlan1779 opened this issue Jun 25, 2024 · 1 comment
Labels

Comments

@zhaowenlan1779
Copy link

See title. All is good since it returns Accept, but DecodeProcessProposalTxs is failing with error

Msg Type: types.MsgProposedOperations, Error: 
github.com/cosmos/cosmos-sdk/x/auth/tx.NewTxConfigWithOptions.DefaultTxDecoder.func1
    github.com/cosmos/[email protected]/x/auth/tx/decoder.go:23
github.com/dydxprotocol/v4-chain/protocol/app/process.DecodeProposedOperationsTx
    github.com/dydxprotocol/v4-chain/protocol/app/process/proposed_operations.go:27
github.com/dydxprotocol/v4-chain/protocol/app/process.DecodeProcessProposalTxs
    github.com/dydxprotocol/v4-chain/protocol/app/process/transactions.go:103
github.com/dydxprotocol/v4-chain/protocol/app.(*App).createProposalHandlers.FullNodeProcessProposalHandler.func2
    github.com/dydxprotocol/v4-chain/protocol/app/process/full_node_process_proposal.go:42
github.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).ProcessProposal
    github.com/cosmos/[email protected]/baseapp/abci.go:547
github.com/cosmos/cosmos-sdk/server.cometABCIWrapper.ProcessProposal
    github.com/cosmos/[email protected]/server/cmt_abci.go:40
github.com/cometbft/cometbft/abci/client.(*unsyncLocalClient).ProcessProposal
    github.com/cometbft/[email protected]/abci/client/unsync_local_client.go:125
github.com/cometbft/cometbft/proxy.(*appConnConsensus).ProcessProposal
    github.com/cometbft/[email protected]/proxy/app_conn.go:89
github.com/cometbft/cometbft/state.(*BlockExecutor).ProcessProposal
    github.com/cometbft/[email protected]/state/execution.go:166
github.com/cometbft/cometbft/consensus.(*State).defaultDoPrevote
    github.com/cometbft/[email protected]/consensus/state.go:1408
github.com/cometbft/cometbft/consensus.(*State).enterPrevote
    github.com/cometbft/[email protected]/consensus/state.go:1340
github.com/cometbft/cometbft/consensus.(*State).handleCompleteProposal
    github.com/cometbft/[email protected]/consensus/state.go:2111
github.com/cometbft/cometbft/consensus.(*State).handleMsg
    github.com/cometbft/[email protected]/consensus/state.go:909
github.com/cometbft/cometbft/consensus.(*State).receiveRoutine
    github.com/cometbft/[email protected]/consensus/state.go:835
expected 2 wire type, got 0: tx parse error: Decoding tx bytes failed

This is apparently because DefaultMarketPriceDecoder (used by non-validating full nodes) always return 0 for GetTxOffset, which results in ProcessProposal attempting to parse the vote extension as a tx.

Copy link

linear bot commented Jun 25, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant