Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npm version 0.10.1 (newest) angular-modal-service.min.js.map is missing #185

Open
wojski opened this issue Nov 16, 2016 · 2 comments
Open
Assignees
Milestone

Comments

@wojski
Copy link

wojski commented Nov 16, 2016

Hi.
After used the newest version of angular-modal-service i received 404 on server log:
6.11.16 01:31:03 404 GET /node_modules/angular-modal-service/dst/dst/angular-modal-service.min.js.map

As I can see it's occurring because of missing "dist/angular-modal-service.min.js.map" file in downloaded package (v. 0.10.1).
Comparing to the source on github I can see that this file is still in repo and still in use.
But after remove from "angular-modal.service.*.js" line "//# sourceMappingURL=./dst/angular-modal-service.min.js.map" 404 dissapear, and everything working as expected.
Is that some obsolete code?

@eekboom
Copy link

eekboom commented Dec 20, 2016

Having the same problem when trying to upgrade from 0.6.10 to 0.10.1.
Something is fishy here: Note the double "dst/dst" in the path in the 404 error line.

@dwmkerr dwmkerr self-assigned this May 20, 2017
@dwmkerr dwmkerr modified the milestones: v0.12, v0.13 May 20, 2017
@dwmkerr
Copy link
Owner

dwmkerr commented May 20, 2017

Confirmed bug, due to the way the source map is built. See: mishoo/UglifyJS#1905

Will aim to fix for the next release.

@dwmkerr dwmkerr closed this as completed May 20, 2017
@dwmkerr dwmkerr reopened this May 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants