Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store data in Astropy Table #32

Open
michaelbaisch opened this issue Sep 10, 2024 · 3 comments
Open

Store data in Astropy Table #32

michaelbaisch opened this issue Sep 10, 2024 · 3 comments

Comments

@michaelbaisch
Copy link
Contributor

Hello,

Currently, all data is stored in the EDGE class as an array of dictionaries, and a CSV is manually created using the write_output() method. I suggest using an Astropy Table to store all data. Astropy Tables support many calculations and filtering options, as well as a variety of output formats.

I believe it makes sense to be more compatible with Astropy by using these tables. Additionally, some operations might become simpler and cleaner, and writing data to disk would be more convenient in many different formats. We might even try to align more closely with the structure and naming conventions of photutils.segmentation.SourceCatalog (to_table() returns a QTable; DEFAULT_COLUMNS defines the columns).

Additionally, we might only return that table as a result and let the user of ASTRiDE choose how and in which format to write the data, since it’s so simple. Using QTable would also enable us to use quantities with units.

Greetings,
Michael

@dwkim78
Copy link
Owner

dwkim78 commented Sep 25, 2024

Hi Michael,

As long as the astropy and phoutils don't slow down the ASTRiDE performance (i.e. wall-clock time), I'm agree with this. As I have experienced slow photutils performance before, we need to check the QTable performance as well.

Cheers,

Dae-Won

@dwkim78
Copy link
Owner

dwkim78 commented Dec 17, 2024

Hi Michael,

I'd like to add you to the project as a collaborator because you've made more modifications recently. If you accept, we'll discuss future updates and fixes.

Cheers,

Dae-Won

@michaelbaisch
Copy link
Contributor Author

Hello Dae-Won,

I'm honored by the invite. But my priorities have shifted a bit recently. If I come back to using ASTRiDE in the future, I will let you know.

Greetings,
Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants