Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support creating Streak instance with data instead of filename #31

Open
michaelbaisch opened this issue Sep 10, 2024 · 1 comment
Open

Comments

@michaelbaisch
Copy link
Contributor

Hello,

I believe it would be very useful to create a Streak instance by passing image data and optionally a WCS instance. Currently, only passing a filename to a FITS file is possible. This limitation prevents easy modification of the image beforehand (without writing it to disk and passing that path), which could be very useful, for example, for rebinning.

I suggest adding another way to create a Streak instance with the image data and optionally a WCS instance. As far as I can see, the FITS header is only used for wcsinfo. Therefore, I also propose storing the WCS as an instance variable and using it in the xy2sky() methods directly, without reading the FITS header from disk again.

Greetings,
Michael

@dwkim78
Copy link
Owner

dwkim78 commented Sep 25, 2024

Hi Michael,

This sounds really good.

Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants