Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LogstashLogger's Tagged Formatter and ActiveSupport Tagged Formatter are no longer the same #166

Open
krainboltgreene opened this issue Jan 15, 2021 · 0 comments
Open

LogstashLogger's Tagged Formatter and ActiveSupport Tagged Formatter are no longer the same #166

krainboltgreene opened this issue Jan 15, 2021 · 0 comments

Comments

@krainboltgreene
Copy link

krainboltgreene commented Jan 15, 2021 •
edited
Loading

Would the owner of this library desire an update to the new code?

It looks like it deviates in 3 ways:

  1. (major) The module is now called with new().call()
  2. #push_tags is more efficient, handles non-strings better
  3. #current_tags handles multiple instances in a more thread-safe way
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krainboltgreene