Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unsupported game] Maniac Mansion NES is unsupported #51

Open
1 task done
dwatteau opened this issue Feb 21, 2022 · 0 comments
Open
1 task done

[Unsupported game] Maniac Mansion NES is unsupported #51

dwatteau opened this issue Feb 21, 2022 · 0 comments
Labels
bug Something isn't working help wanted External contributions wanted! unsupported game This game (or variant) should be supported, but isn't

Comments

@dwatteau
Copy link
Owner

Summary

There is a NES version of Maniac Mansion, but unfortunately ScummRp/ScummTr has not support for it.

(Of course, the .LFL files need to be properly extracted, first.)

$ scummtr -L

[...]
maniacv1    | Maniac Mansion (V1)                                | 00.LFL
maniacv2    | Maniac Mansion (V2)                                | 00.LFL
[...]

Well, actually…

/*
 * Game definitions
 */

const GameDefinition ScummRp::_gameDef[] =
{
        { "maniacv1", "Maniac Mansion (V1)", "00.LFL", "%.2u.LFL", GID_MANIAC,
          1, 0xFF, 0xFF, GTCFMT_8SEP16, BFMT_SIZEONLY, 4, GF_OLD_BUNDLE },
        { "maniacv2", "Maniac Mansion (V2)", "00.LFL", "%.2u.LFL", GID_MANIAC,
          2, 0xFF, 0xFF, GTCFMT_8SEP16, BFMT_SIZEONLY, 4, GF_OLD_BUNDLE },
//      { "maniacnes", "Maniac Mansion (NES)", "00.LFL", "%.2u.LFL", GID_MANIAC,
//        1, 0xFF, 0xFF, GTCFMT_8SEP16, BFMT_SIZEONLY, 4, GF_OLD_BUNDLE | GF_NES },

It looks like Thomas tried to work on it back then, but it's still incomplete and that's probably why it has been disabled by default (plus, Thomas probably tried to add support for it back in 2003, while ScummVM had support for it "only" around 2007).

Depending on an extract_mm_nes set of LFL files also means that our job is probably easier, now?

Impacted games

Maniac Mansion

ScummTR versions

v0.5.0, v0.4.2, v0.4.1, v0.4.0

I own a legitimate game

  • I promise that my game does NOT come from an illegal source, such as "abandonware" websites
@dwatteau dwatteau added bug Something isn't working unsupported game This game (or variant) should be supported, but isn't help wanted External contributions wanted! labels Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted External contributions wanted! unsupported game This game (or variant) should be supported, but isn't
Projects
None yet
Development

No branches or pull requests

1 participant