Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure _checkDupOffset() doesn't remove the wrong duplicate #31

Closed
dwatteau opened this issue Apr 5, 2021 · 1 comment
Closed

Ensure _checkDupOffset() doesn't remove the wrong duplicate #31

dwatteau opened this issue Apr 5, 2021 · 1 comment
Assignees

Comments

@dwatteau
Copy link
Owner

dwatteau commented Apr 5, 2021

Note to myself: I need to make sure that _checkDupOffset() doesn't remove the wrong duplicate when it finds one. Otherwise the game could be playable, until an internal script error happens under some particular circumstances…

Ideas on how to check this:

  • Check against other variants not having the bug (other platforms, other languages…)
  • Try reading the scripts through descumm
  • Use another SCUMM resource explorer
@dwatteau
Copy link
Owner Author

dwatteau commented Feb 9, 2022

The current workarounds look OK, although I didn't do any 100% thorough gameplay of them after the duplicates are removed. For my workaround addition to Loom in particular, removing the other duplicate does crash the game, so yeah it looks good the way it is (and that's how I stumbled upon issue #45).

My only doubt is in the MONKEY1-FLOPPY-VGA I introduced in commit dc94b2a, but anyway it had to be disabled for the ScummTR 0.5.0 release, because of the #47 bug.

So let's close this.

@dwatteau dwatteau closed this as completed Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant