Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated signal is not unique #51

Open
enkessler opened this issue May 8, 2017 · 1 comment
Open

Generated signal is not unique #51

enkessler opened this issue May 8, 2017 · 1 comment

Comments

@enkessler
Copy link

The wait/signal usage pattern described in the Readme says that "signal puts the specified token back on the semaphore, or generates a unique new token and puts that back if none is passed". Looking at the signal method, however, it looks like it will never generate a new token. It will either use the provided token or use 1 as the token.

def signal(token = 1)
  token ||= generate_unique_token

  # other stuff
end
@rfyiamcool
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants