Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue name is not passed correctly when checking the job #30

Open
shawnm0705 opened this issue Apr 11, 2019 · 0 comments
Open

Queue name is not passed correctly when checking the job #30

shawnm0705 opened this issue Apr 11, 2019 · 0 comments

Comments

@shawnm0705
Copy link

Issue: Queue names in sqs-plain.php is not detected. Always use 'default-handler' instead.

Reason of the issue:
in the latest Laravel (v5.8), in Illuminate/Queue/Queue.php it is
createPayload($job, $queue, $data = '')
(ref: https://laravel.com/api/5.8/Illuminate/Queue/Queue.html#method_createPayload)

However, in the /src/Sqs/Queue.php here, it is createPayload($job, $data = '', $queue = null), which is not align to the parent.
So that the queue name is passed as $data here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant