rusk-wallet: Add confirmation if sending to own address #3049
Conversation
|
I actually don't think we need this check. |
| @@ -379,6 +387,17 @@ fn confirm(cmd: &Command, wallet: &Wallet<WalletFile>) -> anyhow::Result<bool> { | |||
| if let Address::Public(_) = sender { | |||
| println!(" > ALERT: THIS IS A PUBLIC TRANSACTION"); | |||
| } | |||
|
|
|||
| // check if we are sending to our own address | |||
| if wallet.claim(rcvr.clone()).is_ok() | |||
There was a problem hiding this comment.
The essence of the issue to prevent possibly erroneous transaction when the user pays a fee when tokens are not actually moving (try to transfer Dusk from any account to the SAME account). Currently, the PR warns also if you move tokens between profiles but should prompt the user only when the receiver address == sender address.
There was a problem hiding this comment.
There are cases though when creating a transaction to the same address is what a user wants to do, i.e. when sending a memo, or when merging phoenix notes. An extra confirmation in those cases is not desirable.
And as I argue above, we already prompt the user to confirm the transaction and double check the sender and receiver address. Imo this is more than enough and adding another confirmation is not needed.
There was a problem hiding this comment.
@moCello It was not obvious to me when I first tried it. My intention was to transfer Dusk from my public account to my shielded account. I thought I could do it using the transfer menu. I guess I am not the only one who misunderstands how to transfer tokens from the public account to the shielded one without reading the docs first. Since the fee is charged, I think it is better to ask one more time before executing the transaction.
There was a problem hiding this comment.
To me, what you are describing hints more to a documentation problem though.
But I won't block adding this extra check.
However, if we add the extra confirmation (beyond the already existing confirmation of the transfer), it should only appear when an attempt is made to:
- transfer public DUSK
- without a memo
- when the sender and receiver is the exact same moonlight account.
Closes #2959