rusk-wallet: Add stdout_format flag to binary #2700
+153
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about situations where the wallet file is missing? Should the error be JSON wrapped to also be parsable? What if there's no stake for a given key? Should it return that as an error or just have all values default to zero? Since having no stake or rewards is equivalent to not having a key that stakes. |
|
@HDauven I added a |
herr-seppia
previously requested changes
Oct 21, 2024
herr-seppia
reviewed
Oct 25, 2024
Add `to_json` for `RunResult` Remove duplicate code in main.rs
herr-seppia
requested changes
Nov 21, 2024
Comment on lines
-722
to
-723
| } else { | ||
| writeln!(f, "> No active stake found for this key")?; |
Comment on lines
+324
to
+325
| if want_json { | ||
| stdout_res = run_res.to_json(); |
There was a problem hiding this comment.
Can you put an if else and avoid to "run_res.to_string()"?
| impl fmt::Display for RunResult<'_> { | ||
| impl<'a> RunResult<'a> { | ||
| /// Convert the ran result into json | ||
| pub fn to_json(&self) -> String { |
There was a problem hiding this comment.
Why don't you implement serde::Serialize for RunResult?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2664
to_jsonforRunResultFetch moonlight address
Find stake-info