Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent gate ordering #799

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Fix inconsistent gate ordering #799

merged 1 commit into from
Dec 18, 2023

Conversation

moCello
Copy link
Member

@moCello moCello commented Dec 14, 2023

Resolves #797

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #799 (83e016b) into master (16145dc) will increase coverage by 0.02%.
The diff coverage is 95.91%.

❗ Current head 83e016b differs from pull request most recent head 812cabe. Consider uploading reports for the commit 812cabe to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #799      +/-   ##
==========================================
+ Coverage   85.07%   85.10%   +0.02%     
==========================================
  Files          57       57              
  Lines        4048     4047       -1     
==========================================
  Hits         3444     3444              
+ Misses        604      603       -1     
Files Coverage Δ
src/commitment_scheme/kzg10/key.rs 84.28% <100.00%> (ø)
src/composer/builder.rs 80.43% <100.00%> (ø)
src/composer/compiler.rs 99.44% <100.00%> (+<0.01%) ⬆️
src/composer/prover.rs 95.54% <100.00%> (ø)
src/permutation.rs 92.83% <100.00%> (ø)
src/proof_system/linearization_poly.rs 99.21% <100.00%> (ø)
src/proof_system/proof.rs 95.94% <100.00%> (ø)
src/proof_system/quotient_poly.rs 100.00% <100.00%> (ø)
src/proof_system/widget/arithmetic/proverkey.rs 92.85% <100.00%> (ø)
...roof_system/widget/ecc/curve_addition/proverkey.rs 85.71% <ø> (ø)
... and 13 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16145dc...812cabe. Read the comment docs.

Copy link
Member

@HDauven HDauven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small suggestion in the test file.

tests/append_gate.rs Outdated Show resolved Hide resolved
tests/append_gate.rs Show resolved Hide resolved
tests/append_gate.rs Show resolved Hide resolved
tests/append_gate.rs Show resolved Hide resolved
tests/append_gate.rs Show resolved Hide resolved
tests/append_gate.rs Show resolved Hide resolved
tests/append_gate.rs Show resolved Hide resolved
tests/append_gate.rs Show resolved Hide resolved
@moCello moCello requested a review from HDauven December 15, 2023 14:04
Copy link
Member

@HDauven HDauven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This PR also renames output wire from `c` to `o` internally to remove
confusion with `q_c`, the constant wire selector.

Resolves #797
@moCello moCello merged commit 902396e into master Dec 18, 2023
8 checks passed
@moCello moCello deleted the mocello/797 branch December 18, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent gate ordering
2 participants