Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent JIT bomb attacks #351

Open
HDauven opened this issue Apr 8, 2024 · 1 comment
Open

Prevent JIT bomb attacks #351

HDauven opened this issue Apr 8, 2024 · 1 comment
Labels
fix:vulnerability Issues related to fix vulnerabilities of the architecture or software type:rfc Changing the behaviour of something already defined

Comments

@HDauven
Copy link
Member

HDauven commented Apr 8, 2024

Summary

With Cranelift, it is currently possible for a malicious actor to do a JIT bomb. Wasmtime currently provides a single-pass compiler that should prevent this called Winch.

Possible solution design or implementation

Switch from Cranelift to Winch to prevent potential JIT bombs.
@HDauven HDauven added fix:vulnerability Issues related to fix vulnerabilities of the architecture or software type:rfc Changing the behaviour of something already defined labels Apr 8, 2024
@HDauven HDauven added this to the Mainnet milestone Apr 8, 2024
@HDauven HDauven mentioned this issue Apr 10, 2024
Closed
@ureeves ureeves mentioned this issue Apr 15, 2024
Merged
@ureeves
Copy link
Member

ureeves commented Apr 16, 2024

This cannot be implemented until wasmtime implements fuel-based interruption
bytecodealliance/wasmtime#8090

@HDauven HDauven mentioned this issue Apr 24, 2024
Closed
3 tasks
@HDauven HDauven changed the title Migrate from Cranelift to Winch Prevent JIT bomb attacks Jun 27, 2024
@HDauven HDauven removed this from the Mainnet milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix:vulnerability Issues related to fix vulnerabilities of the architecture or software type:rfc Changing the behaviour of something already defined
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HDauven @ureeves