-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for a HostQuery
to take &mut Session
#328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ureeves
force-pushed
the
session-host-fn
branch
from
February 10, 2024 01:34
c5e2ede
to
0617474
Compare
ureeves
force-pushed
the
single-instance-per-call
branch
from
February 12, 2024 12:30
c4b7675
to
2509e52
Compare
ureeves
force-pushed
the
session-host-fn
branch
from
February 12, 2024 12:42
0617474
to
0a4d176
Compare
ureeves
force-pushed
the
single-instance-per-call
branch
from
February 12, 2024 12:45
2509e52
to
1e7fbdf
Compare
ureeves
force-pushed
the
session-host-fn
branch
from
February 12, 2024 12:45
0a4d176
to
6f27bc1
Compare
ureeves
requested review from
miloszm,
fed-franz,
HDauven,
moCello and
herr-seppia
February 12, 2024 12:46
ureeves
force-pushed
the
single-instance-per-call
branch
from
February 12, 2024 15:30
1e7fbdf
to
cfe6134
Compare
ureeves
force-pushed
the
session-host-fn
branch
from
February 12, 2024 15:31
6f27bc1
to
6c10ed8
Compare
ureeves
force-pushed
the
session-host-fn
branch
from
February 12, 2024 16:30
6c10ed8
to
a4198da
Compare
moCello
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
miloszm
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This will allow for downstream to make use of a `Session` while defining host functions, enabling contracts to be called during their execution. Resolves: #327
ureeves
force-pushed
the
session-host-fn
branch
from
February 13, 2024 10:33
a4198da
to
c56c63e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow for downstream to make use of a
Session
while defining host functions, enabling contracts to be called during their execution.Resolves: #327