Skip to content

Commit

Permalink
GHA: fix duplicate step id (#5273)
Browse files Browse the repository at this point in the history
Task/Issue URL:
https://app.asana.com/0/inbox/1157893581871899/1208764131137352/1208764131137354

### Description
Fix duplicate ids and fastlane config for deployment


---
- To see the specific tasks where the Asana app for GitHub is being
used, see below:
  - https://app.asana.com/0/0/1208764131137352
  • Loading branch information
malmstein authored Nov 14, 2024
1 parent 0e35d75 commit 16a947e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 10 deletions.
12 changes: 3 additions & 9 deletions .github/workflows/release_upload_play_store.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
destination-path: $HOME/jenkins_static/com.duckduckgo.mobile.android/

- name: Assemble the bundle
run: ./gradleW bundleRelease -PuseUploadSigning
run: ./gradlew bundleRelease -PuseUploadSigning

- name: Capture App Bundle Path
id: capture_output
Expand All @@ -72,21 +72,15 @@ jobs:
echo "bundle_path=$output" >> $GITHUB_OUTPUT
- name: Upload bundle to Play Store
id: create_app_bundle
id: upload_bundle_play
run: |
bundle exec fastlane deploy_playstore
- name: Upload Universal APK to Github
id: create_app_bundle
id: upload_bundle_github
run: |
bundle exec fastlane deploy_github
- name: Upload APK as artifact
uses: actions/upload-artifact@v4
with:
name: duckduckgo-${{ steps.generate_version_name.outputs.version }}.apk
path: duckduckgo.apk

- name: Create Asana task when workflow failed
if: ${{ failure() }}
uses: duckduckgo/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ platform :android do
version = props["VERSION"]
releaseNotes = release_notes_github()
apkPath = "app/build/outputs/apk/play/release/duckduckgo-#{version}-play-release.apk"
token = ENV["GITHUB_UPLOAD_TOKEN"]
token = ENV["GH_TOKEN"]

UI.message ("Upload new app version to GitHub\nVersion: #{version}\nRelease Notes:\n=====\n#{releaseNotes}\n=====\n")

Expand Down

0 comments on commit 16a947e

Please sign in to comment.