Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for COPY and COPY to local parquet file #265

Open
JelteF opened this issue Oct 9, 2024 · 1 comment
Open

Tests for COPY and COPY to local parquet file #265

JelteF opened this issue Oct 9, 2024 · 1 comment
Labels
COPY Issues related to COPY enhancement New feature or request good first issue Good for newcomers testing Improves testing and/or CI
Milestone

Comments

@JelteF
Copy link
Collaborator

JelteF commented Oct 9, 2024

We completely broke COPY support without us noticing. That problem is being fixed by #264, but it might happen again if we don't add some tests. For the 0.1.0 release we can manage with manual testing though.

I think the easiest way would be to have a test write locally to parquet and read the resulting file to see that it contains the expected content in parquet format. We currently don't support writing parquet locally but that should be fairly easy to do forcing the COPY to go through DuckDB if it contains a .parquet suffix.

@JelteF JelteF added the testing Improves testing and/or CI label Oct 9, 2024
@JelteF JelteF added this to the 0.2.0 milestone Oct 9, 2024
@JelteF JelteF changed the title Tests for COPY Tests for COPY and COPY to local parquet file Oct 9, 2024
@JelteF JelteF added the enhancement New feature or request label Oct 9, 2024
@mkaruza
Copy link
Collaborator

mkaruza commented Oct 11, 2024

For testing we should check situations where filename part of COPY statement match table name or column name.
For example this should work with COPY (from COPY .. TO remote perspective):

COPY (SELECT * FROM "s3://remote/csv") TO 's3://remote/csv' (FORMAT CSV, HEADER, FORCE_QUOTE ('s3://remote/csv'));

Where s3://remote/csv is table and/or column name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COPY Issues related to COPY enhancement New feature or request good first issue Good for newcomers testing Improves testing and/or CI
Projects
None yet
Development

No branches or pull requests

2 participants