Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure: test_all_types fails because the correct_answer_map does not have any values for the varint column #66

Closed
rpbouman opened this issue Aug 23, 2024 · 0 comments

Comments

@rpbouman
Copy link
Contributor

Running make test fails with:

TestDuckDBJDBC#test_all_types failed with java.lang.NullPointerException
java.lang.NullPointerException
        at org.duckdb.TestDuckDBJDBC.test_all_types(TestDuckDBJDBC.java:3981)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:566)
        at org.duckdb.test.Runner.runTests(Runner.java:45)
        at org.duckdb.TestDuckDBJDBC.main(TestDuckDBJDBC.java:4525)

The test fails unexpectedly because the correct_answer_map is not populated with the values for the varint column (https://github.com/duckdb/duckdb-java/blob/main/src/test/java/org/duckdb/TestDuckDBJDBC.java#L3854).

Apart from populating the map with the types, It would also be nice to assert that the map contains values for the specified column and then report the column name if they are missing.

@rpbouman rpbouman changed the title Test failure: test_all_types Test failure: test_all_types fails because the correct_answer_map does not have any values for the varint column Aug 23, 2024
@Mause Mause closed this as completed in 3f5a221 Aug 25, 2024
Mause added a commit that referenced this issue Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant