Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add case-insensitive getters on resultSet #40

Open
egillax opened this issue Jun 21, 2024 · 2 comments · May be fixed by #43
Open

Add case-insensitive getters on resultSet #40

egillax opened this issue Jun 21, 2024 · 2 comments · May be fixed by #43

Comments

@egillax
Copy link

egillax commented Jun 21, 2024

I believe the getters for resultSet should be case insensitive:

Column names used as input to getter methods are case insensitive.

From here

I'm having an issue where I'm adding duckdb support to an application that already supports a number of other database systems through jdbc. There the results are always fetched like:

resultSet.getString('VERSION')

for a column version. This currently doesn't work in duckdb.
@Mause
Copy link
Member

Mause commented Jun 22, 2024

Probably just needs a change here?

duckdb-java/src/main/java/org/duckdb/DuckDBResultSet.java

Line 314 in dedf7b7

if (meta.column_names[col_idx].contentEquals(columnLabel)) {

@jghoman jghoman linked a pull request Jun 24, 2024 that will close this issue
Open
@jghoman
Copy link
Contributor

jghoman commented Jun 24, 2024

Probably just needs a change here?

That worked. Added change and unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make result set getColumn by name case insensitive. Add test for same. jghoman/duckdb-java
3 participants
@jghoman @Mause @egillax