-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request : add support for Fabric OneLake #43
Comments
I might have a chance to test / implement this soon. Note to self: See object_store AzureConfigKey |
I think this is blocked due to some bigger issues with the duckdb_azure plugin. i.e. duckdb/duckdb-azure#58 |
it working now, so closing the issue |
This works again if we set the |
@samansmink Any reason to keep that "else"? if the endpoint is empty then it will be handled by the underlying rust code anyway, i believe. |
Also, i'm not sure if / how the duckdb org can set up an integration test to a Fabric workspace in the same way that they have the other Azure integration tests. Any suggestions @djouallah ? |
No strong opinion, it was added to simply set the endpoint to be the same as DuckDB is using. Sorry if this is a stupid question, I have not played with fabric yet, but looking at https://learn.microsoft.com/en-us/fabric/onelake/onelake-access-api i would expect the following to work:
I guess I need to create a DuckDB testing fabric account and hook that up in our CI. I'm a little busy this week but I can look into that next week! |
I'm not sure, but I think that unless you tell delta-rs to use the fabric endpoint then it might still be using
👍🏻 |
it is working !!! it is so easy when you know it :) |
twist, it works great inside fabric notebook but outside Fabric using my laptop, I get this errors, for reference, it works fine with polars and daft, so it is not an authentication issue
|
@gdubya any idea what is this error
|
How did you create the secret? |
That appears to be correct. Hmm, I'm not sure, sorry. I'll have to test it later this evening. |
don't ask got it working !mkdir -p /etc/pki/tls/certs |
@gdubya and @samansmink thanks, that was a colab specific issue, it works fine in my windows machine |
it seems Azure is already supported using SPN, we need only to pass
The text was updated successfully, but these errors were encountered: