Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccountName shouldn't be required #69

Open
whatsthecraic opened this issue Aug 2, 2024 · 0 comments
Open

AccountName shouldn't be required #69

whatsthecraic opened this issue Aug 2, 2024 · 0 comments

Comments

@whatsthecraic
Copy link

whatsthecraic commented Aug 2, 2024

It shouldn't be mandatory to specify the AccountName in the azure connection string:

auto storage_account_name_pos = connection_string.find("AccountName=");
if (storage_account_name_pos == std::string::npos) {
	throw InvalidInputException("A invalid connection string has been provided.");
}

It's not required by the Azure API and the connection string can be used to specify different settings, e.g. the blob endpoint or the SAS token.

I think the error message is also too generic: A invalid connection string has been provided. => why is it invalid?

CC @quentingodeau , author of the snippet according to git blame

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant