Inconsistent behavior of indentation rule for abstract functions

[quezak]

Description
Indentation for functions with a long, multiline argument list behaves differently for abstract and concrete functions -- see example. The error message is also weird, as it says to use 4 spaces (== 1 indent in my case), when the line already uses 4 spaces, and the error disappears if I use a double indent there (which is 8 spaces).

Steps to reproduce

• The command you used to lint: npx solium --file test.sol
• The solidity code over which you ran the linter

pragma solidity 0.5.10;

contract Test {
    function concreteFn(
        uint256 _long,
        uint256 _arg,
        uint256 _list
    ) internal returns (bool success) {
        return true;
    }

    function abstractFn(
        uint256 _long,
        uint256 _arg,
        uint256 _list
    ) internal returns (bool success);
    // ^ this yields: error    Only use indent of 4 spaces.
    // also: the line already uses 4 spaces indent!

    function abstractFn2(
        uint256 _long,
        uint256 _arg,
        uint256 _list
        ) internal returns (bool success);
    // ^ this doesn't, but is inconsistent with concreteFn [and ugly ;) ]
}

• Contents of your .soliumrc.json file

{
  "extends": "solium:recommended",
  "plugins": ["security"],
  "rules": {
    "indentation": ["error", 4]
  }
}

• Contents of your .soliumignore: node_modules

Expected behavior
abstractFn shouldn't yield errors, as it's formatted consistently with concreteFn

Operating System
Linux

Linter version
Solium version 1.2.4

[duaraghav8]

I'm able to reproduce this, thanks for reporting

[nfurfaro]

Hey, any progress on this? I've modified the indentation of my closong parens on all my abstract functions as a workaround... but would be great if this wasn't an issue.

[duaraghav8]

@nfurfaro This is one of the issues I've been working on (https://github.com/duaraghav8/Ethlint/projects/6) but I recently hit a roadblock. It may be around for 2-3 months. I see that you've had to change your indent style. If comment directives work for you instead of changing your code, I recommend using them to ignore indent lint issues.

[nfurfaro]

Thanks for the suggestion, I will do that. Good luck with this!

…

On Sat., Nov. 30, 2019, 5:32 a.m. Raghav Dua, ***@***.***> wrote: @nfurfaro <https://github.com/nfurfaro> This is one of the issues I've been working on (https://github.com/duaraghav8/Ethlint/projects/6) but I recently hit a roadblock. It may be around for 2-3 months. I see that you've had to change your indent style. If comment directives work for you instead of changing your code, I recommend using them to ignore indent lint issues. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#268?email_source=notifications&email_token=AECDLFBGPEKGMTGSYAC7JUTQWJMPNA5CNFSM4H4Q4OHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFQFE5A#issuecomment-559960692>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AECDLFGKP45LG67PZR7MJA3QWJMPNANCNFSM4H4Q4OHA> .