From 060ecebbcf43a9e88d2315dbca4ea0b5ac29c610 Mon Sep 17 00:00:00 2001
From: duaraghav8 <duaraghav8@gmail.com>
Date: Sun, 27 May 2018 10:26:13 +0530
Subject: [PATCH] changes

---
 lib/rules/double-quotes.js  |  2 +-
 lib/rules/magic-to-const.js | 26 +++++++++++++-------------
 test/lib/rules.js           |  1 -
 3 files changed, 14 insertions(+), 15 deletions(-)

diff --git a/lib/rules/double-quotes.js b/lib/rules/double-quotes.js
index d4df026..93d345e 100644
--- a/lib/rules/double-quotes.js
+++ b/lib/rules/double-quotes.js
@@ -55,7 +55,7 @@ module.exports = {
             if (!doubleQuotesLiteralRegExp.test(nodeText)) {
                 context.report({
                     node: node,
-                    message: `'${node.value}': String Literals must be quoted with "double quotes" only.`
+                    message: "'" + node.value + "': String Literals must be quoted with \"double quotes\" only."
                 });
             }
         }
diff --git a/lib/rules/magic-to-const.js b/lib/rules/magic-to-const.js
index 29c92be..3783220 100644
--- a/lib/rules/magic-to-const.js
+++ b/lib/rules/magic-to-const.js
@@ -5,6 +5,8 @@
 
 "use strict";
 
+const allowedMagicNumbers = [0, 1];
+
 module.exports = {
 
     meta: {
@@ -18,36 +20,34 @@ module.exports = {
         schema: []
     },
 
-    create: function(context) {
+    create(context) {
 
         function inspectLiteral(emitted) {
             if (emitted.exit) {
                 return;
             }
 
-            let parentNode = context.getSourceCode().getParent(emitted.node);
-            if (_isNumber(emitted.node.value) &&
-                !_constantInitialization(parentNode) &&
-                !_allowedMagicNumber(emitted.node.value)) {
+            const { node } = emitted,
+                parentNode = context.getSourceCode().getParent(node);
 
+            if (isNumber(node.value) && !isAConstantInitialization(parentNode) && !isAllowed(node.value)) {
                 context.report({
-                    node: emitted.node,
-                    message: `Value '${emitted.node.value}' should be extracted to a constant`
+                    node,
+                    message: `Value '${node.value}' should be extracted to a constant`
                 });
             }
         }
 
-        function _isNumber(value) {
+        function isNumber(value) {
             return typeof(value) === "number";
         }
 
-        function _constantInitialization(parentNode) {
-            return parentNode.type === "StateVariableDeclaration" &&
-                    parentNode.is_constant === true;
+        function isAConstantInitialization(parentNode) {
+            return (parentNode.type === "StateVariableDeclaration" && parentNode.is_constant === true);
         }
 
-        function _allowedMagicNumber(value) {
-            return value === 0 || value === 1;
+        function isAllowed(value) {
+            return allowedMagicNumbers.includes(value);
         }
 
         return {
diff --git a/test/lib/rules.js b/test/lib/rules.js
index dc40e11..b1cce27 100644
--- a/test/lib/rules.js
+++ b/test/lib/rules.js
@@ -212,7 +212,6 @@ describe("Checking exported rules object", function() {
         // We extend ALL solium core rules and eliminate a few by setting their severity to 0.
         // The rest of the rules should all be available.
         // The below count will keep changing with every change in the number of core rules that exist in solium.
-
         Object.keys(ruleDescriptions).length.should.equal(27);
 
         done();