Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring to use the new ncsdk2 #19

Open
cpagravel opened this issue Jun 28, 2018 · 3 comments
Open

Refactoring to use the new ncsdk2 #19

cpagravel opened this issue Jun 28, 2018 · 3 comments

Comments

@cpagravel
Copy link

Hello there,

I've refactored the code to use the new ncsdk2 API. Should I make a PR?

@duangenquan
Copy link
Owner

yes please.

@duangenquan
Copy link
Owner

do you have an easy way to switch to the new ncsdk2 API? Or will it detect the hardware automatically?

@cpagravel
Copy link
Author

cpagravel commented Jun 29, 2018

I'm not sure I understand what you mean by "detect the hardware automatically".

Perhaps you're referring to detecting which version of the API is installed? In that case, no, I don't. It is possible to determine the API version from regex'ing the copyright year in the output of mvNCCheck. (2016 is version 1 and 2017 is version 2). Though I think a nicer solution would be to make a tag with support for ncsdk version 1.

I will make a pull request and you can have a look for yourself. Maybe you have a better implementation in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants