Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple convolution radii and thresholds in multivariate mode #2709

Open
9 of 22 tasks
davidalbo opened this issue Oct 5, 2023 · 1 comment · May be fixed by #3034
Open
9 of 22 tasks

Allow multiple convolution radii and thresholds in multivariate mode #2709

davidalbo opened this issue Oct 5, 2023 · 1 comment · May be fixed by #3034
Assignees
@davidalbo @hertneky
Labels
component: code cleanup Code cleanup and maintenance issue priority: medium Medium Priority reporting: NRL METplus Naval Research Laboratory METplus Project type: enhancement Improve something that it is currently doing
Milestone
MET-12.1.0

Comments

@davidalbo
Copy link
Contributor

davidalbo commented Oct 5, 2023 •
edited
Loading

Describe the Enhancement

  • Allow multiple convolution radii and thresholds without quilting.
  • Currently disallowed in multivariate mode.
  • Can also do this with multiple METplus configurations (I think) in case this does not get done.
  • Possibly also allow quilting if it is trivial to do so.

Time Estimate

40 hours

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

Work must be completed by 12/30 for NRL METplus funding

Funding Source

NRL METplus 7730022

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next official version or Backlog of Development Ideas
  • For the next official version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@davidalbo davidalbo added type: enhancement Improve something that it is currently doing component: code cleanup Code cleanup and maintenance issue priority: medium Medium Priority alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Oct 5, 2023
@davidalbo davidalbo added this to the MET 12.0.0 milestone Oct 5, 2023
@JohnHalleyGotway JohnHalleyGotway added the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Oct 3, 2024
@JohnHalleyGotway JohnHalleyGotway removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Nov 11, 2024
@DanielAdriaansen DanielAdriaansen moved this from 🟢 Ready to 🏗 In progress in MET-12.1.0 Development Nov 12, 2024
@JohnHalleyGotway JohnHalleyGotway added the reporting: NRL METplus Naval Research Laboratory METplus Project label Nov 14, 2024
@davidalbo
Copy link
Contributor Author

Added both quilting and non-quilting options.
Without quilting all inputs (forecast and obs) need to have the same number N of convolution radii and thresholds, with one mvmode run for the first set, one for the second set, etc. for a total of N runs.

With quilting all inputs must have the same number of convolution radii N, and all inputs must have the same number of convolution thresholds M, but N and M can differ. N*M mvmode runs are performed.

@davidalbo davidalbo linked a pull request Dec 10, 2024 that will close this issue
Feature 2709 mvmode multithreshradii #3034
Open
17 tasks
@DanielAdriaansen DanielAdriaansen moved this from 🏗 In progress to 🔎 In review in MET-12.1.0 Development Dec 11, 2024
JohnHalleyGotway pushed a commit that referenced this issue Dec 13, 2024
Per #2709, updates to fix SonarQube code smells.
b6360c5
JohnHalleyGotway pushed a commit that referenced this issue Dec 14, 2024
Per #2709, fix compilation problem I introduced with SonarQube fixes.
4db78a0
JohnHalleyGotway pushed a commit that referenced this issue Dec 14, 2024
Per #2709, eliminate SonarQube bug that was flagged
5491a87
JohnHalleyGotway pushed a commit that referenced this issue Dec 14, 2024
Per #2709, fix typo in docs
aa7dda1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidalbo davidalbo

@hertneky hertneky

Labels
component: code cleanup Code cleanup and maintenance issue priority: medium Medium Priority reporting: NRL METplus Naval Research Laboratory METplus Project type: enhancement Improve something that it is currently doing
Projects
MET-12.1.0 Development
Status: 🔎 In review
Milestone
MET-12.1.0
Development

Successfully merging a pull request may close this issue.

Feature 2709 mvmode multithreshradii dtcenter/MET
3 participants
@davidalbo @JohnHalleyGotway @hertneky