feat: add python 3.11 support, fix installation and ci #328
Conversation
BREAKING CHANGE: drop python 2 support, minimul required python is 3.8+
|
Are there any plans to accept this PR? Echoing what @jmahlik said - it would be great to have pyGAM work smoothly with more recent Python versions. I'm also happy to help with the project although I'm quite the newbie when it comes to open source. |
|
@dswah are you willing to give someone else maintainer rights so that the community can take this over? |
|
Yes i am happy to give the community maintainer rights! |
|
Maintainer question aside, I don't get why you closed instead of merging this PR |
|
I didnt merge because the main functionality from this PR has been in production since March 2023 after the merge of PR #332 Admittedly, I should have had a conversation with the original contributor a month before that, because there were a few issues with this PR (that were addressed in #332). Specifically:
I'm sorry @jmahlik because I never commented on your PR when the time was appropriate, I didn't thank you for your contribution, and I closed this PR a year later with no comment to you personally. Your initiative was 100% correct. I acted wrongly and am sorry. |
|
No worries @dswah. I saw the other PR so should have closed this one, just didn't get around to clicking the button in time. |
Who has maintainer rights? I currently have two open PRs I'd like merged. |
BREAKING CHANGE: drop python 2 support, minimul required python is 3.8+
pyproject.tomlCloses #319 #312
@dswah would you mind having a look at this PR? pyGAM is having some difficulties with newer versions of python and numpy.
It looks like there hasn't been a release in quite some time. Wondering if you still have interest in maintaining this project? I am willing to help maintain the project if possible. Let me know thoughts :).