Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please Release New Versions When Making Breaking Changes #209

Open
hoffm386 opened this issue Dec 14, 2024 · 0 comments
Open

Please Release New Versions When Making Breaking Changes #209

hoffm386 opened this issue Dec 14, 2024 · 0 comments

Comments

@hoffm386
Copy link

Hello, I am working on troubleshooting an issue that occurred due to e2bd391.

I built a Docker image that used aequitas==1.0.0 and numpy==1.23.5 earlier this year.

Then this week, I attempted to build a new image from this same specification. The build failed, because when that commit was made, the Aequitas NumPy dependency changed from numpy==1.23.5 to numpy>=1.24.4. Thus, the exact version of NumPy that was required by this package previously, 1.23.5, was no longer permitted as the NumPy version after this change.

This level of change in dependencies should trigger a new release of Aequitas. End users should reasonably expect that aequitas==1.0.0 is going to have the same dependencies in December that it had in August.

If you had bumped the version, even just to 1.0.1, I would not be having this issue. However a more appropriate version might be 1.1.0, because patch updates should only be used for bug fixes, whereas minor updates add functionality. See Semantic Versioning documentation.

Please follow best practices for releases going forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant