Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial tests for the datacite module #48

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Add initial tests for the datacite module #48

merged 3 commits into from
Jun 26, 2024

Conversation

evgepab
Copy link
Contributor

@evgepab evgepab commented Jun 25, 2024

No description provided.

@evgepab
Copy link
Contributor Author

evgepab commented Jun 25, 2024

SInce FileCache.file_reads wasn't applicable, in some cases I used SELECT DISTINCT container_id FROM dc_works, since each container corresponds to a file. However, one thought was to create a file_tar_cache.py or datacite_tar_cache.py in order to be able to test if the files are always being read properly similarly to the other modules. Do you find this excessive or necessary?

@dspinellis
Copy link
Owner

SInce FileCache.file_reads wasn't applicable, in some cases I used SELECT DISTINCT container_id FROM dc_works, since each container corresponds to a file. However, one thought was to create a file_tar_cache.py or datacite_tar_cache.py in order to be able to test if the files are always being read properly similarly to the other modules. Do you find this excessive or necessary?

No need for additional caching or verification is needed. Tests don't need to ape the ones of other modules. Use those as guidance on how to implement them, but focus on exercising the functionality of the DataCite code.

@dspinellis
Copy link
Owner

I merged this, even though it doesn't pass lint to simplify your work and allow you to move forward.

@dspinellis dspinellis merged commit d03819d into dspinellis:datacite Jun 26, 2024
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants