Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Loading State #5

Open
Nathan-Somto opened this issue May 18, 2023 · 2 comments
Open

Add Loading State #5

Nathan-Somto opened this issue May 18, 2023 · 2 comments
Assignees

Comments

@Nathan-Somto
Copy link

Just a suggestion, a loading component can be created, while data is being fetched from the api .

@Ayo-Awe
Copy link
Contributor

Ayo-Awe commented May 19, 2023

@seyiadisa Could you fetch the modal data from state rather than from the API?

@Nathan-Somto
Copy link
Author

@seyiadisa nice job on the project , but one thing i noticed is that the main page file is a client component, if you wanted all the data fetching to happen on the client, why use next js? why not plain old react? next js 13 simplifies the data fetching process tremendously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants