Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP2030 - sine.c cleanup #33

Open
8 tasks
drowe67 opened this issue Nov 24, 2023 · 0 comments
Open
8 tasks

WP2030 - sine.c cleanup #33

drowe67 opened this issue Nov 24, 2023 · 0 comments
Labels
Work Package A chunk of work for the FreeDV project

Comments

@drowe67
Copy link
Owner

drowe67 commented Nov 24, 2023

  • review source code and comments
  • Hamming -> Hann window
  • some tests, e.g. estimate amplitude on sine wave, analysis/synthesis test with contrived pitch
  • check variable names match codec2.pdf
  • consider making trapezoidal window function a triangular function, as I think with TW == 0.05 that is effectively what we are doing.
  • consider making notation a bit more consistent, e.g. n for time index, k for DFT index, m for harmonic index
  • In v est function distinguish Am from model->A
  • decide between phi (source code) for phase or theta (latex), it should be consistent
@drowe67 drowe67 added the Work Package A chunk of work for the FreeDV project label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Work Package A chunk of work for the FreeDV project
Projects
None yet
Development

No branches or pull requests

1 participant