Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP2020 - NLP cleanup #32

Open
8 tasks
drowe67 opened this issue Nov 23, 2023 · 0 comments
Open
8 tasks

WP2020 - NLP cleanup #32

drowe67 opened this issue Nov 23, 2023 · 0 comments
Labels
Work Package A chunk of work for the FreeDV project

Comments

@drowe67
Copy link
Owner

drowe67 commented Nov 23, 2023

Clean up nlp.c clean up and add unit tests (ctests) to support

  • remove todos
  • review comments
  • remove profiling marcos (I don't think they are used any more)
  • remove 8-16 kHz resampling functions and 16 kHz support (we can discuss but I don't think it's needed any more)
  • come up with some unit tests, e.g. to support ports to other platforms. Consider tests that have a statistical pass criteria, a floating point error may cause non-exact output on different machines. For example we could count gross errors over a sample file against had estimates, and/or use contrived signals such as codec2-dev/estn0
  • unit test for pitch refinement. Make sure it really is refining. These days we probably have enough CPU for the full MBE cost function method. Optional - determine if we still need refinement.
  • align variable names with codec.pdf
  • bring plnlp.m back from codec2-dev, edit it, add instructions for it's use
@drowe67 drowe67 added the Work Package A chunk of work for the FreeDV project label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Work Package A chunk of work for the FreeDV project
Projects
None yet
Development

No branches or pull requests

1 participant