Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine DiffNets with existing functionality #20

Closed
martinvoegele opened this issue Jul 21, 2021 · 2 comments
Closed

Combine DiffNets with existing functionality #20

martinvoegele opened this issue Jul 21, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@martinvoegele
Copy link
Collaborator

We would like to run DiffNets from the PENSA package and make it work with existing features.
In addition, the currently implemented methods might benefit from using featurization functions that so far are only implemented with DiffNets. First steps in this direction:

  • Move DiffNets preprocessing/featurization to the corresponding modules and adapt the output format.
  • Adapt DiffNets input to use PENSA-style features.
  • Harmonize functionality across feature readers (e.g. whitening).
@martinvoegele
Copy link
Collaborator Author

martinvoegele commented Jul 22, 2021

The corresponding branch is 20-combine-diffnets.

I have moved the following:

  • data_processing functionality to preprocessing.whitening_xyz
  • CLI scripts to the scripts folder
  • tests to tests/test_diffnets*.py

Some dependencies will still need to be adapted accordingly.

The submodule diffnets.analysis is not yet included in the package because we want to avoid a dependence on enspara if possible.

@martinvoegele martinvoegele added the enhancement New feature or request label Jan 20, 2022
@martinvoegele
Copy link
Collaborator Author

We found that including this would introduce too many dependencies that would end up making PENSA too inflexible to be used with any kind of other ML frameworks. So I am closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants