Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html-webpack-plugin/lib/hooks is internal, breaks with 5.6.2 #23

Closed
aleho opened this issue Oct 23, 2024 · 2 comments
Closed

html-webpack-plugin/lib/hooks is internal, breaks with 5.6.2 #23

aleho opened this issue Oct 23, 2024 · 2 comments

Comments

@aleho
Copy link

aleho commented Oct 23, 2024

require('html-webpack-plugin/lib/hooks').getHtmlWebpackPluginHooks(compilation).alterAssetTags.tapAsync(

According to jantimon/html-webpack-plugin#1866 (comment) this should be fixed by using the correct module:

require('html-webpack-plugin').getCompilationHooks(compilation).alterAssetTags.tapAsync(

There's a fix with 5.6.3, but the author suggests to update the code anyway.

@drolsen
Copy link
Owner

drolsen commented Oct 23, 2024

I've published a new 1.5.0 version.
Please give this a run, but know that it bumps the min node version up from 14.17.0 to 18.17.0

Thanks!

@drolsen drolsen closed this as completed Oct 23, 2024
@aleho
Copy link
Author

aleho commented Oct 24, 2024

Thank you very much!

Just updated the project (to 1.5.4) and everything (I use) seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants