Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix improper handling of Annotated when not outermost generic type #123

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

jayqi
Copy link
Member

@jayqi jayqi commented Jul 16, 2024

Handle typing.Annotated with typenames>=1.3.0. Closes #122.

Copy link
Contributor

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.4%. Comparing base (664a3f7) to head (da26dd6).

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #123     +/-   ##
=======================================
- Coverage   98.4%   98.4%   -0.1%     
=======================================
  Files         19      19             
  Lines        824     819      -5     
=======================================
- Hits         811     806      -5     
  Misses        13      13             
Files Coverage Δ
erdantic/core.py 97.6% <100.0%> (-0.1%) ⬇️

@jayqi jayqi merged commit 2db369b into main Jul 16, 2024
17 checks passed
@jayqi jayqi deleted the 122-annotated branch July 16, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with Optional Annotated types
1 participant