Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xcode 16 build #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Xcode 16 build #12

wants to merge 2 commits into from

Conversation

aehlke
Copy link
Contributor

@aehlke aehlke commented Jul 24, 2024

Resolves compiler issues

@drewmccormack
Copy link
Owner

If I understand the solution, it is to make the actor methods of CoordinatedFileManager async. What annoys me a little about it is that there are no async methods in there. Eg. NSFIleCoordinator is not async. So I don't understand why it should be necessary, though I'm sure you are correct that it works.

Is this a fix for the recent issue that shows up in Swift 6? That seems to be a compiler bug, and I have reported it.

I'm just wondering if there is some other solution that doesn't require making the methods async.

@aehlke
Copy link
Contributor Author

aehlke commented Jul 25, 2024

This fixes the Swift 6 issues - the async changes may not be necessary but worked for my use case, so I stopped investigating (my other attempts weren't working) and I understand if you don't want to merge yet. Thanks for reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aehlke @drewmccormack