Add rows to hasMany join table in order provided #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, they were added in reverse order
dxg
commented
Jun 27, 2023
|
|
||
| var Association = Associations.pop(); |
There was a problem hiding this comment.
This was the offending line. Rather than switch to .shift I decided to simplify by leveraging async.eachSeries.
dxg
commented
Jun 27, 2023
| return cb(); | ||
| } | ||
|
|
||
| var other = associations.pop(); |
There was a problem hiding this comment.
I also changed the order in which hasOne associations are saved from reverse to provided order.
No tests for this as it doesn't really affect anything.
dxg
commented
Jun 27, 2023
|
|
||
| args.push(next); |
There was a problem hiding this comment.
This was a bit complicated and it wasn't clear what it's actually doing (there's an optional opts parameter which gets passed to the hook).
Rewritten to make it more explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, they were added in reverse order