Bugfix: wrong column used in JOIN clause when querying a reverse association #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the 'JOIN...ON' clause was not the right one (fixes dresende#446)
|
tests ;) ? |
|
It looks OK, but it would be great to have a specific test case to avoid having that mistake again. It's very easy to be confused changing code in (reversed) associations. |
|
After writing a test, it turned out that not only did Anyways, it's fixed and in master! Hopefully going to release a new version in the next few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Fixes #446) When querying a reverse association, one of the two columns used in the generated 'JOIN...ON' clause was not the right one. One of the columns being used was the table's primary key, whereas the expected one was the foreign key.