Pool and debug settings always are true #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assed to ORM.connect would always be set to true. - Wrote a test to demonstrate the passing.
dresende
added a commit
that referenced
this pull request
Dec 12, 2013
Pool and debug settings always are true
|
Thanks Diogo =P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example:
ORM.connect("mysql://something:nothing@beep/boop?pool=false&debug=false", ...)
will still set debug == true and pool == true because calling the boolean constructor on a non-empty string always yields true.
This fix simply checks the val of debug and pool, and if they are falsy, sets them to false, or true otherwise. (still maintains the null-defaulting case).