Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in property definition #382

Merged
merged 1 commit into from
Nov 9, 2013
Merged

Typo in property definition #382

merged 1 commit into from
Nov 9, 2013

Conversation

interlock
Copy link
Contributor

There is much dispute about the name of this attribute, but the EMCA6 spec says 'writable' not 'writeable'. Spent some time trying to figure out why we could not get spy's in our testing libs to run on instance methods... mystery solved!

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperty

There is much dispute about the name of this attribute, but the EMCA6 spec says 'writable' not 'writeable'. Spent some time trying to figure out why we could not get spy's in our testing libs to run on instance methods... mystery solved!

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperty
@dresende
Copy link
Owner

dresende commented Nov 9, 2013

Thank you :)

dresende added a commit that referenced this pull request Nov 9, 2013
Typo in property definition
@dresende dresende merged commit 8401717 into dresende:master Nov 9, 2013
@interlock interlock deleted the patch-1 branch November 9, 2013 18:32
@interlock interlock restored the patch-1 branch November 9, 2013 18:32
@interlock interlock deleted the patch-1 branch November 9, 2013 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants