Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One more stack overflow on model w/ association save #338

Closed
Gromina opened this issue Sep 16, 2013 · 5 comments
Closed

One more stack overflow on model w/ association save #338

Gromina opened this issue Sep 16, 2013 · 5 comments

Comments

@Gromina
Copy link

Gromina commented Sep 16, 2013

I recreated my case when I get stackoverflow on save -
Gromina@1a7f78d

sorry for quick and dirty code.

npm test  #will show failng case

I use OSX 10.8.4
node v0.10.17

@dresende
Copy link
Owner

Thank you for making a test of it. I can replicate the stack overflow, I'll investigate.

@dresende
Copy link
Owner

I'm creating a fix and releasing a new version. I created an instance state called instance_saving to avoid this kind of loops (created because of reversed associations).

@dresende
Copy link
Owner

And thank you for the it.only code, I didn't know that about mocha. Great feature! :)

@dresende
Copy link
Owner

Released orm v2.1.2.

@Gromina
Copy link
Author

Gromina commented Sep 17, 2013

At first - thank you for good work of building ORM for node. I hope it will become something like ActiveRecord in ruby world.
And of course, thank you for lighting fast fixing of the bug.
About mocha - yes, it has its secrets. Most of them are in manual though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants