Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change con.end() to con.release() for pooled mysql connections #335

Closed
snej51 opened this issue Sep 11, 2013 · 3 comments
Closed

change con.end() to con.release() for pooled mysql connections #335

snej51 opened this issue Sep 11, 2013 · 3 comments

Comments

@snej51
Copy link

snej51 commented Sep 11, 2013

There are changes made to the actual mysql driver when using pooled connections:

mysqljs/mysql#537

Perhaps it is necessary to change con.end() to con.release() because of this warning:

Calling conn.end() to release a pooled connection is deprecated. In next version calling conn.end() will be restored to default conn.end() behavior. Use conn.release() instead.

thx Jens

@dresende
Copy link
Owner

Thank you for reminding this. It's not released just yet, but I'm making a change to check if release is defined and use it instead. Otherwise it will continue to call end.

@snej51
Copy link
Author

snej51 commented Sep 14, 2013

Thank you!

@dresende
Copy link
Owner

[email protected] seems to have the con.release but I'll keep the code for a while so people can update orm without having to update mysql.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants