Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(facade): add facade comments #4264

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

feat(facade): add facade comments #4264

wants to merge 11 commits into from

Conversation

VicKun4937
Copy link
Contributor

  • add selection facade api

@VicKun4937 VicKun4937 requested a review from wzhudev as a code owner December 9, 2024 08:35
Copy link

github-actions bot commented Dec 9, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 31.49606% with 87 lines in your changes missing coverage. Please review.

Project coverage is 33.63%. Comparing base (c9c1e5d) to head (b618c3c).
Report is 10 commits behind head on dev.

Files with missing lines Patch % Lines
packages/sheets/src/facade/f-worksheet.ts 0.00% 58 Missing ⚠️
packages/sheets/src/facade/f-selection.ts 0.00% 8 Missing ⚠️
packages/sheets-ui/src/facade/f-worksheet.ts 0.00% 5 Missing ⚠️
...commands/mutations/set-gridlines-color.mutation.ts 64.28% 5 Missing ⚠️
packages/core/src/sheets/worksheet.ts 0.00% 4 Missing ⚠️
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 4 Missing ⚠️
...engine-render/src/components/sheets/spreadsheet.ts 0.00% 2 Missing ⚠️
...c/commands/commands/set-gridlines-color.command.ts 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4264      +/-   ##
==========================================
- Coverage   33.64%   33.63%   -0.01%     
==========================================
  Files        2495     2497       +2     
  Lines      128258   128432     +174     
  Branches    28746    28775      +29     
==========================================
+ Hits        43146    43204      +58     
- Misses      85112    85228     +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 9, 2024

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 46 seconds
commit  b618c3c
info  For more information, see full report

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/sheets/src/facade/typedef.ts Outdated Show resolved Hide resolved
@VicKun4937 VicKun4937 requested a review from jikkai as a code owner December 11, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants