Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(definedName): set current sheet name #4204

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Dec 2, 2024

close #2187

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 2, 2024

Playwright test results

passed  19 passed
flaky  1 flaky

Details

stats  20 tests across 9 suites
duration  5 minutes, 17 seconds
commit  a6ea39c
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.69%. Comparing base (5baf0d0) to head (a6ea39c).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...ets-ui/src/views/defined-name/DefinedNameInput.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4204   +/-   ##
=======================================
  Coverage   33.68%   33.69%           
=======================================
  Files        2490     2490           
  Lines      128071   128073    +2     
  Branches    28716    28718    +2     
=======================================
+ Hits        43145    43150    +5     
+ Misses      84926    84923    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dushusir Dushusir marked this pull request as ready for review December 2, 2024 09:20
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Dec 2, 2024
@Dushusir Dushusir requested a review from DR-Univer December 2, 2024 09:20
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaolixin7
Copy link

@Dushusir 点定义名称未跳到对应区域
2024_12_6 10_56_09 video.webm

@univer-bot
Copy link

univer-bot bot commented Dec 6, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@Dushusir The point definition name does not jump to the corresponding area
2024_12_6 10_56_09 video.webm

@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Dec 6, 2024
@Dushusir Dushusir force-pushed the dushusir/fix-bugs1202 branch from 466e289 to a6ea39c Compare December 6, 2024 08:03
@Dushusir Dushusir added qa:untested This PR is ready to be tested and removed qa:rejected labels Dec 6, 2024
@Dushusir
Copy link
Member Author

Dushusir commented Dec 6, 2024

@Dushusir 点定义名称未跳到对应区域 2024_12_6 10_56_09 video.webm

dev 原有选区问题已经修复。已 rebase dev,请复测下

@univer-bot
Copy link

univer-bot bot commented Dec 6, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@Dushusir The point definition name did not jump to the corresponding area 2024_12_6 10_56_09 video.webm

dev The original selection problem has been fixed. Already rebase dev, please retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants