Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): pictures support writing to the clipboard #4086

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Conversation

Gggpound
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@Gggpound Gggpound requested review from jikkai and Jocs as code owners November 16, 2024 08:48
Copy link

github-actions bot commented Nov 16, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Nov 16, 2024

Playwright test results

passed  19 passed
flaky  1 flaky

Details

stats  20 tests across 9 suites
duration  5 minutes, 18 seconds
commit  eb47fc5
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

@Gggpound Gggpound force-pushed the feat-doc-copy-1116 branch 3 times, most recently from e560134 to 70dc685 Compare November 16, 2024 12:19
@Gggpound Gggpound requested a review from ybzky as a code owner November 19, 2024 02:45
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 155 lines in your changes missing coverage. Please review.

Project coverage is 33.76%. Comparing base (3cf0e3b) to head (eb47fc5).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ocs-ui/src/services/clipboard/clipboard.service.ts 0.00% 78 Missing ⚠️
...ui/src/services/clipboard/udm-to-html/convertor.ts 50.00% 28 Missing ⚠️
...ontrollers/doc-drawing-update.render-controller.ts 0.00% 20 Missing ⚠️
...ui/src/services/clipboard/html-to-udm/converter.ts 15.78% 16 Missing ⚠️
...ers/render-controllers/doc-clipboard.controller.ts 0.00% 8 Missing ⚠️
.../services/clipboard/clipboard-interface.service.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4086      +/-   ##
==========================================
- Coverage   33.78%   33.76%   -0.03%     
==========================================
  Files        2457     2457              
  Lines      127631   127762     +131     
  Branches    28571    28608      +37     
==========================================
+ Hits        43126    43141      +15     
- Misses      84505    84621     +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@oumomomo oumomomo added good first issue Considered relatively to solve and good for new contributors qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed good first issue Considered relatively to solve and good for new contributors labels Nov 21, 2024
@Gggpound Gggpound merged commit bf8329f into dev Nov 21, 2024
9 checks passed
@Gggpound Gggpound deleted the feat-doc-copy-1116 branch November 21, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants