Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify the model equation code a bit #60

Open
drbenvincent opened this issue Nov 30, 2018 · 0 comments
Open

simplify the model equation code a bit #60

drbenvincent opened this issue Nov 30, 2018 · 0 comments
Labels

Comments

@drbenvincent
Copy link
Owner

drbenvincent commented Nov 30, 2018

At the moment we have some silliness in the model equations because we are extracting information from pandas DataFrames. Ideally we'd be able to use dot indexing (ie attribute look up) so you can do

θ.logk

rather than

θ['logk'].values

The same thing applies to the designs which are also held in a pandas DataFrame. For example, we have to do this data['DA'].values rather than data.DA.

This is just unnecessary faff which makes the models less clear than they should be.

Ideas

  1. One idea is that I'm not using Pandas properly.
  2. Use numpy record arrays because they allow for dot indexing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant