fix(android): execute transaction in TiUIFragment only once

execution transaction on every "onAttachedToWindow" causes loss of objects on map refs tidev#13243
drauggres · Feb 3, 2022 · 7fe150f · 7fe150f
1 parent 14859b8
commit 7fe150f
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/android/titanium/src/java/org/appcelerator/titanium/view/TiUIFragment.java b/android/titanium/src/java/org/appcelerator/titanium/view/TiUIFragment.java
@@ -38,6 +38,7 @@ public TiUIFragment(TiViewProxy proxy, Activity activity)
 			fragment = createFragment();
 		} else {
 			TiCompositeLayout container = new TiCompositeLayout(activity, proxy) {
+				private boolean transactionCommited = false;
 				@Override
 				public boolean dispatchTouchEvent(MotionEvent ev)
 				{
@@ -48,12 +49,15 @@ public boolean dispatchTouchEvent(MotionEvent ev)
 				protected void onAttachedToWindow()
 				{
 					super.onAttachedToWindow();
-					FragmentManager manager = ((FragmentActivity) getContext()).getSupportFragmentManager();
-					FragmentTransaction transaction = manager.beginTransaction();
-					transaction.runOnCommit(onCommitRunnable);
-					fragment = createFragment();
-					transaction.add(getId(), fragment);
-					transaction.commitAllowingStateLoss();
+					if (!transactionCommited) {
+						transactionCommited = true;
+						FragmentManager manager = ((FragmentActivity) getContext()).getSupportFragmentManager();
+						FragmentTransaction transaction = manager.beginTransaction();
+						transaction.runOnCommit(onCommitRunnable);
+						fragment = createFragment();
+						transaction.add(getId(), fragment);
+						transaction.commitAllowingStateLoss();
+					}
 				}
 			};
 			container.setId(View.generateViewId());