Skip to content

Commit

Permalink
[lldb][gui] use just '#2' instead of 'frame #2' in the threads/frame …
Browse files Browse the repository at this point in the history
…view

Since the threads/frame view is taking only a small part on the right side
of the screen, only a part of the function name of each frame is visible.
It seems rather wasteful to spell out 'frame' there when it's obvious
that it is a frame, it's better to use the space for more of the function
name.

Differential Revision: https://reviews.llvm.org/D122998
  • Loading branch information
llunak authored and memfrob committed Oct 4, 2022
1 parent 4fd0106 commit f0bdd23
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions lldb/source/Core/IOHandlerCursesGUI.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5016,8 +5016,7 @@ class FrameTreeDelegate : public TreeDelegate {
public:
FrameTreeDelegate() : TreeDelegate() {
FormatEntity::Parse(
"frame #${frame.index}: {${function.name}${function.pc-offset}}}",
m_format);
"#${frame.index}: {${function.name}${function.pc-offset}}}", m_format);
}

~FrameTreeDelegate() override = default;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def test_gui(self):
self.child.expect_exact("Threads")

# The thread running thread_start_routine should be expanded.
self.child.expect_exact("frame #0: break_here")
self.child.expect_exact("#0: break_here")

# Exit GUI.
self.child.send(escape_key)
Expand All @@ -47,7 +47,7 @@ def test_gui(self):
self.child.expect_exact("Threads")

# The main thread should be expanded.
self.child.expect("frame #\d+: main")
self.child.expect("#\d+: main")

# Quit the GUI
self.child.send(escape_key)
Expand Down

0 comments on commit f0bdd23

Please sign in to comment.