Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

production.default.props does not resolve #1

Open
tuhlmann opened this issue Mar 12, 2016 · 3 comments
Open

production.default.props does not resolve #1

tuhlmann opened this issue Mar 12, 2016 · 3 comments

Comments

@tuhlmann
Copy link
Contributor

Hi David,

I'm using Dragonmark Utils in my Clojure side project (the get a bit of Lift feeling :) ).

The doc string says production.default.props would resolve as the default production property file. However that would only resolve if I set -Drun.mode=production, but this isn't recognized as production run mode.

To make it work I set -Drun.mode=prod and name the file prod.default.props.

To make it consistent, either the documentation should be adapted or :production be added to the run modes that trigger production-mode?

You want a pull request?

@dpp
Copy link
Member

dpp commented Mar 12, 2016

👍 on a PR!

@tuhlmann
Copy link
Contributor Author

@dpp Which way do you wanna go?

  • Change documentation
  • Allow :production along with :prod
  • Replace :prod with :production

@dpp
Copy link
Member

dpp commented Mar 12, 2016

Have prop == production and update the docs indicating that either is acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants