This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
[feature request] unify the same field type definition in different places #363
Assignees
Labels
Comments
pouchrobot
added
kind/feature
kind/feature-request
|
/assign me |
|
What is the status of it ? Could you please keep up with the latest developments with us? |
|
@starnop Have finished. Submit it within this week. |
|
@fengzixu Are you still willing to complete this job? If so, could you please do it as soon as possible? If not, please let me know. THX> 😄 |
|
@starnop Sure. Let me submit a PR within this week. |
sungjunyoung
pushed a commit
to sungjunyoung/Dragonfly
that referenced
this issue
May 8, 2022
* feat: handler Signed-off-by: Gaius <[email protected]> * feat: add handlers Signed-off-by: Gaius <[email protected]> * feat: add models and service Signed-off-by: Gaius <[email protected]> * feat: models Signed-off-by: Gaius <[email protected]> * feat: migrate Signed-off-by: Gaius <[email protected]> * feat: database Signed-off-by: Gaius <[email protected]> * feat: create Signed-off-by: Gaius <[email protected]> * feat: CDN CURD Signed-off-by: Gaius <[email protected]> * fix: cdn CURD Signed-off-by: Gaius <[email protected]> * feat: scheduler CURD Signed-off-by: Gaius <[email protected]> * feat: security group CURD Signed-off-by: Gaius <[email protected]> * feat: cdn instances CURD Signed-off-by: Gaius <[email protected]> * feat: associated CURD Signed-off-by: Gaius <[email protected]> * fix: id type Signed-off-by: Gaius <[email protected]> * fix: association Signed-off-by: Gaius <[email protected]> * fix: rest Signed-off-by: Gaius <[email protected]> * feat: health and prometheus Signed-off-by: Gaius <[email protected]> * feat: remove swagger Signed-off-by: Gaius <[email protected]> * feat: ginprometheus Signed-off-by: Gaius <[email protected]> * feat: add cache Signed-off-by: Gaius <[email protected]> * feat: gorm naming Signed-off-by: Gaius <[email protected]> * feat: rename Signed-off-by: Gaius <[email protected]> * feat: rename host to hostname Signed-off-by: Gaius <[email protected]> * feat: rename host to hostname Signed-off-by: Gaius <[email protected]> * feat: add manager grpc Signed-off-by: Gaius <[email protected]> * feat: security_group Signed-off-by: Gaius <[email protected]> * feat: security_group Signed-off-by: Gaius <[email protected]> * feat: manager grpc Signed-off-by: Gaius <[email protected]> * feat: grpc Signed-off-by: Gaius <[email protected]> * feat: grpc Signed-off-by: Gaius <[email protected]> * feat: add grpc internal get cdn Signed-off-by: Gaius <[email protected]> * feat: grpc Signed-off-by: Gaius <[email protected]> * feat: config Signed-off-by: Gaius <[email protected]> * feat: cache Signed-off-by: Gaius <[email protected]> * feat: grpc cache Signed-off-by: Gaius <[email protected]> * feat: grpc cache Signed-off-by: Gaius <[email protected]> * feat: cache time Signed-off-by: Gaius <[email protected]> * feat: database mysql Signed-off-by: Gaius <[email protected]> * feat: manager init Signed-off-by: Gaius <[email protected]> * feat: update scheduler Signed-off-by: Gaius <[email protected]> * feat: config Signed-off-by: Gaius <[email protected]> * feat: config Signed-off-by: Gaius <[email protected]> * feat: init db Signed-off-by: Gaius <[email protected]> * feat: init db Signed-off-by: Gaius <[email protected]> * feat: grpc Signed-off-by: Gaius <[email protected]> * feat: grpc Signed-off-by: Gaius <[email protected]> * feat: dynconfig Signed-off-by: Gaius <[email protected]> * feat: register Signed-off-by: Gaius <[email protected]> * feat: tag Signed-off-by: Gaius <[email protected]> * feat: add Signed-off-by: Gaius <[email protected]> * feat: manager Signed-off-by: Gaius <[email protected]> * feat: config Signed-off-by: Gaius <[email protected]> * feat: grpc Signed-off-by: Gaius <[email protected]> * feat: keepAlive Signed-off-by: Gaius <[email protected]> * feat: keepAlive Signed-off-by: Gaius <[email protected]> * test: scheduler config Signed-off-by: Gaius <[email protected]> * fix: lint Signed-off-by: Gaius <[email protected]> * fix: typo Signed-off-by: Gaius <[email protected]> * feat: typo Signed-off-by: Gaius <[email protected]> * feat: typo Signed-off-by: Gaius <[email protected]> * test: cdn Signed-off-by: Gaius <[email protected]> * test: cdn Signed-off-by: Gaius <[email protected]> * feat: remove println Signed-off-by: Gaius <[email protected]> * feat: manager Signed-off-by: Gaius <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
name: Feature Request
about: Suggest your excellent idea for this project
Why you need it?
For reaching a good result about refactoring the dfget, we should unify the type definition in different places. Besides, the operation of unifying type can reduce redundant logic of type conversion.
How it could be?
For this feature, I think that I should know carefully code of dfget and pick up logic about using some type definition incorrectly. Finally, I will revise it.
Other related information
This issue is the sub-question of #347
The text was updated successfully, but these errors were encountered: